----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45173/#review124862 -----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java (line 2052) <https://reviews.apache.org/r/45173/#comment187559> This does not test if the new member does not recover any primaries at all. I think we should add an assertion for the number of primaries to be between say 8 and 12 on each member. - Swapnil Bawaskar On March 22, 2016, 7:13 p.m., Sai Boorlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45173/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 7:13 p.m.) > > > Review request for geode and Darrel Schneider. > > > Bugs: GEODE-1056 > https://issues.apache.org/jira/browse/GEODE-1056 > > > Repository: geode > > > Description > ------- > > modified the test to count unexpected failures > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java > abf546dd8053db690c829ab1bb6339935e3005fe > > Diff: https://reviews.apache.org/r/45173/diff/ > > > Testing > ------- > > > Thanks, > > Sai Boorlagadda > >
