----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45170/#review124896 -----------------------------------------------------------
Ship it! Ship It! - Jens Deppe On March 22, 2016, 6:36 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45170/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 6:36 p.m.) > > > Review request for geode, Jens Deppe and Jinmei Liao. > > > Bugs: GEODE-693 > https://issues.apache.org/jira/browse/GEODE-693 > > > Repository: geode > > > Description > ------- > > GEODE-693: convert to JUnit 4 and use RetryRule > > * Convert ClientAuthorizationTestBase and all of its subclasses to JUnit 4 > * RetryRule to ClientPostAuthorizationDUnitTest.testAllPostOps > * Remove @author tags > * Convert from public variables and methods to private > * Convert from static to instance variables and methods > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationDUnitTest.java > 9271cd1 > > geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTestBase.java > c7eed57 > > geode-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java > 496c3a2 > > geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientAuthorizationDUnitTest.java > 8a78378 > > geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientPostAuthorizationDUnitTest.java > e0502a2 > > geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTwoDUnitTest.java > f146160 > > geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java > 984e5f1 > > geode-cq/src/test/java/com/gemstone/gemfire/security/ClientCQPostAuthorizationDUnitTest.java > 1388bac > > geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java > ec08b22 > > geode-cq/src/test/java/com/gemstone/gemfire/security/MultiuserAPIDUnitTest.java > c5a1afe > > geode-cq/src/test/java/com/gemstone/gemfire/security/MultiuserDurableCQAuthzDUnitTest.java > 68d52d9 > > Diff: https://reviews.apache.org/r/45170/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Kirk Lund > >
