-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45162/
-----------------------------------------------------------
(Updated March 22, 2016, 10:29 p.m.)
Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan
Smith, and xiaojian zhou.
Changes
-------
Applied changes. Will rerun precheckin.
Bugs: GEODE-911
https://issues.apache.org/jira/browse/GEODE-911
Repository: geode
Description
-------
The stop() method was setting the EventProcessor to null before cleaning up the
queues. This led to no queues being cleaned up because the method getQueues
would return null if the eventProcessor was null.
This includes refactoring a few methods in WanTestBase that pretty much did the
same thing but was duplicated all over.
The Parallel queues do not have this problem because the EventProcessor is not
set to null "for test purposes." It seems like this should also be set to null
as well and the tests that rely on it, should be fixed.
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueue.java
430409a
geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderImpl.java
8f0070f
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
2f44fce
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentSerialGatewaySenderOperationsOffHeapDUnitTest.java
e24f593
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderOperationsDUnitTest.java
ea6de11
Diff: https://reviews.apache.org/r/45162/diff/
Testing
-------
Thanks,
Jason Huynh
