-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45058/#review124911
-----------------------------------------------------------




geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java
 (lines 386 - 387)
<https://reviews.apache.org/r/45058/#comment187609>

    Actually, I think this test *should* be checking whether the REST admin 
HTTP service and the REST dev HTTP service can run on the same system. To that 
end, line 385 should be deleted as this line prevents the REST admin HTTP 
service from starting. 
    
    That is the only reason I can see starting a Manager at all. If the REST 
admin service is not started, then there's no point in even starting a Manager.


- Jens Deppe


On March 22, 2016, 6:37 p.m., Jianxia Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45058/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 6:37 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jens Deppe, and 
> Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Set jmx-manager-port to 0 so that it does not allow remote client 
> connections. Hence avoid starting the agent. Then there is no worry about the 
> port already in use for the agent. HTTP service is still started though.
> 
> 
> Diffs
> -----
> 
>   
> geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java
>  29aab32 
> 
> Diff: https://reviews.apache.org/r/45058/diff/
> 
> 
> Testing
> -------
> 
> RestAPIsWithSSLDUnitTest
> 
> 
> Thanks,
> 
> Jianxia Chen
> 
>

Reply via email to