----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45449/#review125979 -----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java (line 236) <https://reviews.apache.org/r/45449/#comment188897> Is this nanos or millis? We would need some consistency here. Otherwise it gets really confusing really quickly geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java (line 272) <https://reviews.apache.org/r/45449/#comment188899> Maybe we could use "startInNanos". Less confusing as just general "start" geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java (line 286) <https://reviews.apache.org/r/45449/#comment188900> Maybe we could print out the time unit. "Elapsed time(ms): " would be more helpful - Udo Kohlmeyer On March 29, 2016, 10:08 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45449/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 10:08 p.m.) > > > Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Aligned test code with ConnectionManager.. > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java > bb407a4 > > Diff: https://reviews.apache.org/r/45449/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
