----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45508/#review126503 -----------------------------------------------------------
Ship it! Ship It! - Sai Boorlagadda On March 30, 2016, 10:20 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45508/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 10:20 p.m.) > > > Review request for geode, Sai Boorlagadda and Swapnil Bawaskar. > > > Bugs: GEODE-915 > https://issues.apache.org/jira/browse/GEODE-915 > > > Repository: geode > > > Description > ------- > > add FORCE_INVALIDATE_EVENT fixes to geode: > - new unit test ClientServerForceInvalidateDUnitTest > - ProxyRegionMap now checks for force invalidate before it throws > EntryNotFound > - AbstractRegionMap invalidate now does force invalidate unless the region > is not initialized > > As part of the work also did the following code cleanup work: > 1. Removed the isInvalidate parameter from shouldCreateCBEvent since this > method did the exact same thing all values of this parameter. > 2. Changed cacheWriteBeforeInvalidate to be serverInvalidate since all this > method does is possibly send the invalidate to the server. > 3. EntryEventImpl toString will now include inhibitCacheListenerNotification > if it is true > 4. Removed the unused parameter invokeCallbacks and forceNewEntry from > serverInvalidate > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java > 90589846c778eb91e67def2d19e9ad2fb9dff208 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java > dfd20ef3d619c12a49fd26796ff4b5c3c579e105 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > c727a53bb040f9dfac9f1fda9d685f109b679807 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java > dc9db463e12b07c35a3e2d043dee7dcc6e65f20e > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientServerForceInvalidateDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45508/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
