----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45844/ -----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jianxia Chen, Jens Deppe, and Udo Kohlmeyer. Repository: geode Description ------- ServerLauncher needed to be made aware of auto-reconnect. I changed getCache() to look for a new, reconnected cache and I changed isWaiting() to see if the current cache is in a reconnecting state. I also changed the shutdown logic to cancel reconnect attempts if the cache is in that state when a stop is requested. Diffs ----- geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java 2a8c9f3c232a981fb8123df57c1f207d5de81f4f geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java d3a7050749004fd62975d10024f9e59752700e54 Diff: https://reviews.apache.org/r/45844/diff/ Testing ------- new tests for reconnect and for stopping the server. Precheckin is underway. I ran manual network-down tests as well using iptable manipulation to simulate a network partition with and without the change. Thanks, Bruce Schuchardt
