> On April 6, 2016, 6:36 p.m., Dan Smith wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlVersion.java, > > line 48 > > <https://reviews.apache.org/r/45819/diff/1/?file=1328303#file1328303line48> > > > > Maybe it would be good to add some comments or rename the old versions > > to GEMFIRE_8_2, etc. To someone that doesn't know the history it's not > > cLear why 1.0 comes later > > Jens Deppe wrote: > Not sure if you think this is sufficient?
I guess I think it would be better to rename the old GEMFIRE constants to GEMFIRE_8_2, etc. Otherwise, what happens when geode hits 3.0? We already have a VERSION_3_0 constant! - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45819/#review127402 ----------------------------------------------------------- On April 6, 2016, 4:50 p.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45819/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 4:50 p.m.) > > > Review request for geode, Anthony Baker, Jinmei Liao, Kirk Lund, and Dan > Smith. > > > Repository: geode > > > Description > ------- > > GEODE-386: Change xsd namespace to apache > > With this change I've already pushed the XSD to > http://geode.apache.org/schema/cache/cache-1.0.xsd. This was needed to get > some of the tests to pass. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXml.java > 4f1facbf4b7549df77cceaf0f40145d12640aeee > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlGenerator.java > 57d06b0a091f23633e0bd55ba87f85694746c0da > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlVersion.java > 51e840a95136d48abb4dbf1f4bad839b92dc3ecf > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/GeodeEntityResolver.java > 59d58604da9635cefa0a06bd20d1b399e06c4daf > > geode-core/src/main/resources/META-INF/schemas/schema.pivotal.io/gemfire/cache/cache-9.0.xsd > 1cd356797e7c917d1cc7ab7168814c762b96d408 > > geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml90DUnitTest.java > 21e6c614f090c3d5520d281ca344ebe265d3d4a7 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/AbstractEntityResolverTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlVersionJUnitTest.java > eb4ce86ebd73edbe291ebf7092635b2b8a99c2d0 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/GeodeEntityResolverJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/PivotalEntityResolverJUnitTest.java > 800e5ce83830df2501edeb252335414e8809284b > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/domain/CacheElementJUnitTest.java > bcb88c067221cc00303a004ad48b40a81aefd5fb > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsJUnitTest.java > 0e145013da0e7f994f035a4db949ddd05a15fdaf > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/domain/CacheElementJUnitTest.xml > 269ddcf1eb432230561928a8dae06051fbc68f83 > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewNamed.xml > 3055f31a155444ae9fab1421632088fb1a82299a > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewUnnamed.xml > fb50e6b7e81515fcb3c6079749a041d2e164564e > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewUnnamedExtension.xml > 38f791deeadacd4a9bbf782dc2f9f6c65b2c5d64 > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeReplaceNamed.xml > 4f5b1a16b986d6535271f7db81e00c4536075e1f > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeReplaceUnnamed.xml > 4db37998ea9f3574f1e9c75e9aa46ab2e7084918 > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeReplaceUnnamedExtension.xml > a3238d8a28256e3ab08f9465cc3221446cbae8c1 > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testDeleteNodeUnnamed.xml > b325fbf2c9f2d071c48c3788a116494b9e6116b4 > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.xml > bdefa30be06af9766a22016837018f143b1c36f8 > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsJUnitTest.testBuildSchemaLocationMapAttribute.xml > 832d7569d6a43396cdd3d260258ac7c479707e71 > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsJUnitTest.testBuildSchemaLocationMapEmptyAttribute.xml > 05843bf50d651877c033a19314025acaeb638802 > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsJUnitTest.testBuildSchemaLocationMapMapOfStringListOfStringAttribute.xml > 87b3cac08ceb1538f8b1c5416797b584e02e92f8 > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsJUnitTest.testBuildSchemaLocationMapNullAttribute.xml > 95d11b3499ee036f33bba79ee4c4b39157fa52ac > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsJUnitTest.testQuerySingleElement.xml > 76b851ed5131d1832ed02bd65cb9cc97008e1822 > > geode-lucene/src/test/resources/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlParserIntegrationJUnitTest.createIndex.cache.xml > 47f325089a045fc4f33cba505eafd607e5a0f59d > > geode-lucene/src/test/resources/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlParserIntegrationJUnitTest.parseIndex.cache.xml > 47f325089a045fc4f33cba505eafd607e5a0f59d > > geode-rebalancer/src/test/java/com/gemstone/gemfire/cache/util/AutoBalancerIntegrationJUnitTest.java > 72f4d2f8cd290fe3dfa21393da0565ee8a6e279d > geode-site/website/content/schema/cache/cache-1.0.xsd PRE-CREATION > > Diff: https://reviews.apache.org/r/45819/diff/ > > > Testing > ------- > > > Thanks, > > Jens Deppe > >
