----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45880/ -----------------------------------------------------------
Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou. Repository: geode Description ------- Added a test that expects unsupported exception when creating a lucene index on replicated region Instead of a sleep/wait, instead will use awaitility to wait until async queue size is 0. The todo to flush the queue instead is still there and should be easy to replace the awaitility call Removed the createBasicCache code and merged it with getCache() (This will hopefully remove any chance to accidently createBasicCache and then call getCache() and end up with two caches). getCache() and getService() will now return the cache and luceneservice. renamed a test to be slightly more descriptive. createRegionFirst() to cannotCreateLuceneIndexAfterRegionHasBeenCreated() removed dead code on else block where a root region was being created even though it was not supposed to be and it was also not being used. Diffs ----- geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java 405c986 geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java 159fd46 Diff: https://reviews.apache.org/r/45880/diff/ Testing ------- Thanks, Jason Huynh
