----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46417/#review129930 -----------------------------------------------------------
Ship it! Ship It! - Sai Boorlagadda On April 19, 2016, 11:49 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46417/ > ----------------------------------------------------------- > > (Updated April 19, 2016, 11:49 p.m.) > > > Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai > Boorlagadda. > > > Bugs: GEODE-1238 > https://issues.apache.org/jira/browse/GEODE-1238 > > > Repository: geode > > > Description > ------- > > Reviewed all EntryEventImpl creators > Created two new subclasses to mark ones that are never off-heap > Added annotations and comments on all creators > Added missing release calls > Added TODO comments for distributed tx off-heap work > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ServerRegionProxy.java > 40f240f3f8766a59ae6d37d7b5f470373ecd2020 > > geode-core/src/main/java/com/gemstone/gemfire/internal/admin/ClientStatsManager.java > 20f6dbf46638d1b94558b1648eba7cc540f11a01 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractBucketRegionQueue.java > 2c8f49365a0ee69e3901492f7c460ac01f7c8981 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractLRURegionMap.java > a19ee66c70d60c3e9a2078d463a588bfb5664b6d > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java > e78c8eb8dff69bec9cc0eb548ed5f535dd06dbaf > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java > 1cb7a20b454e28da5190dc376c53766d7fb2d86f > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java > 3946fda76e16b6d16e2057f2570b001152440d2a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java > 6b76c31c8b51810f5e906b97ffb92118a59cee3d > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java > b0ac963e4a2b9f00418e548290c9e74e59eae15a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistPeerTXStateStub.java > cd17770b7027566f1a8d4f90dfbc3362e9b0f59c > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java > 19cc1759db2890e667d3f37ec2e0c5142f65f3af > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java > 10d892a87d71efbffa79ca7a50215f575310dfc6 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateProxyImplOnCoordinator.java > 75a1df7963869de46c4fe0d3bcc70e8dba14fde2 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java > 79ae4eed0f1eac1e259581a4715715d6f56e448e > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java > 2e83cb8c3c4264cfdf2e03c1cacdd1baa3efe106 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java > 467efc66eb6695967894bb4d7fb33e7f80c96b01 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java > 70d39dc0f4e43f6b8902ec9229ad64b03288a26b > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java > 3c87654ac02a358a3eab9379edd2e26c988ad23d > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryExpiryTask.java > cba78028ef2bd2643b28a928b9f4fd6172809c56 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EventIDHolder.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/FilterProfile.java > 90c4dc07d71e4d5ac9f631b67cf746df3081f393 > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/HARegion.java > fa29bf3802c8365e6784f6bde2cb5295357cbc65 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java > a72ca8efe61c9f8558b369f09fea79b0db52b3d7 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java > de6adda74abe9688eabfbb2642f01804faa4ad23 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 3ff48bb11640c5f0792a626f19b0f0af4e9e2fcb > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java > 049f7df872314e6ed0fd7198eadaae0e6736c6ad > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java > 7b4504dbfb8e5edf39d28cf697bf9acfdc66131f > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java > fa7aea19d05e1fc631a1366c10574ac754d8cc70 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java > 4a8c101d103c48aac385ef86db8e1851b8e03c41 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java > ee01c9ba649538fd6d635603495d4597decd7a46 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java > c706e4fedb7cf2117a8b4eade3c512355d335994 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java > 9f51b39bf66d5ea3c6b0829f83d614b656f660a2 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java > 7f3a1385a4b1d1cb4666a0a3504c8aa0070fab3f > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java > d9729a74a0692de5cfbb5728d013760994e25c4a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java > d1644c757d9013f7fea5f877c000cdbfe0643f91 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java > 1964c2829432ac4793aea6a7e532ada5fd9a3103 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java > c948f55dd99a9fcf77617e49715c9f46dabd53e8 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRmtEvent.java > c0493ac78207908ed06e6d2eef2eedc5fe2587c8 > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java > 3bec3975ed1ade4141bf6c85523c4fc89a3f6732 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TimestampedEntryEventImpl.java > fca7d62d5261168ccef5faa5a5a5b93408377df3 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java > a3d1c19a36f4550ecb7915ae6993130d4b006a87 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java > 452c38ff71e832b6bc6c0f991ca3faa9cd50a518 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionTagHolder.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java > a30b9f2f65b9c757ac231c125f43cda08d10864e > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java > 93501aab845bc6b57248853015a6ab3e8d82b7a1 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java > 047d1c7da5ad2a5e2bff7316a64f08fe4c0ab341 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java > 8c14e493949d2011bc41462beb87831bfdff04af > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java > 7fcb0310abdccd6072d02dd63769f072fee5ec60 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java > cace5ccfdd639c99051ef090e1e0762cfd4f511a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java > 77a47b79a2020d5352f30674c949a76fe69651ed > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java > c9079430b75463faa1c15a87454a1bbe495728e2 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/BaseCommand.java > 0be56f9c55f8a0420de573b104401f75061c46b2 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientUpdater.java > 3e43b69398725d32cd393c5da90c0f6969282ae3 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Destroy.java > 888cf6268f8a76269f8001737f2c3c40c2d05a0a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Destroy65.java > 513e90267c0271e3739fa60320b832c6ee267cbc > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java > e2fb686a8190f922dfe4531490eff8b8da8a7e79 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Get70.java > e382c5762bd659036acf9a8216be79ec0e07809d > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Invalidate.java > b037a88845e83560fec6f8f29f66d59473f6fc66 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put.java > 46f44717c8ef748ba85218c3e3cded2085f884c5 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put61.java > 29430918006de735a3d9abd0b7bf7004ccd8418c > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put65.java > 092e2ee796667aad99d05dbebe7f3ea2bbd27daf > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java > a1089656048c07e4567e13b562f52046c653e6fe > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/PartitionedTXRegionStub.java > 323dcc417559cbacc0558d1f4f70440bec218cfd > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java > 4f3488b5d4eb14a4d0481159664af2e8561774a8 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java > 9cde6dd9b63e23ac3903c40e2d364766fffc725a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/BatchDestroyOperation.java > 988c526b2f20c7d4a45d19671ae881cd4e4f74e5 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessor.java > 2cb98eaa25e84b1d44fe372309a89b7c07b539c0 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueue.java > 7c492dbdfea78c4728f037ea1d1474709cd2db7f > > geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java > c9b9ac8cb9ca7c6c9e5c70c8e8334c8877e45bcb > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/UpdateVersionJUnitTest.java > 99d3973beb69cfaa8587fb66a1e7be9babbb48a7 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/EventIdOptimizationDUnitTest.java > 3c3f05247dd1b5ccbba77ec708bc69a4b7c82171 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DestroyEntryPropagationDUnitTest.java > 67dfbeeb4e80950f5a37103235ec160abcc074fd > > geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/UpdateVersionDUnitTest.java > cabacbc96e0928d15a9262cf26f19a62f301196f > > Diff: https://reviews.apache.org/r/46417/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
