----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46668/#review130651 -----------------------------------------------------------
Ship it! Ship It! - Scott Jewell On April 26, 2016, 12:46 a.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46668/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 12:46 a.m.) > > > Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai > Boorlagadda. > > > Bugs: GEODE-1238 > https://issues.apache.org/jira/browse/GEODE-1238 > > > Repository: geode > > > Description > ------- > > When fixing GEODE-1238 getEventForPosition was thought to return a retained > offheap reference. So release calls were added. But this is wrong. > getEventForPosition now uses the @Unretained annotation and the release calls > on it have been removed. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java > 4b4d4d34c892db3e000bc690be785a4040db42a7 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java > 34889aac5501c0186ceb0acfde8fa4fe5ca75bc9 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/FilterProfile.java > 65e7a841cf0c97d241d6e3324923804212a2a3b1 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 4360b2a7837844c3b29b8c43a2036656e2183780 > > Diff: https://reviews.apache.org/r/46668/diff/ > > > Testing > ------- > > precheckin and hydra tests > > > Thanks, > > Darrel Schneider > >
