----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46841/#review131139 -----------------------------------------------------------
Fix it, then Ship it! Fix it and ship it! geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java (line 190) <https://reviews.apache.org/r/46841/#comment195075> change asserts to assertTrue so the test doesn't depend on enabling of java assertions you have the next test correct! - Kirk Lund On April 29, 2016, 4:23 p.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46841/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 4:23 p.m.) > > > Review request for geode, Jinmei Liao and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-1326: Add test for gfsh function execution with ResultCollector > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java > b4d4df1cb96f521b38a0554e2e31658558c6abda > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ToUpperResultCollector.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46841/diff/ > > > Testing > ------- > > > Thanks, > > Jens Deppe > >
