----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46926/#review131595 -----------------------------------------------------------
Fix it, then Ship it! geode-core/build.gradle (line 147) <https://reviews.apache.org/r/46926/#comment195609> Should we catch a more specific exception here? Otherwise if this readSCMInfo code breaks we might never know. - Dan Smith On May 3, 2016, 4:52 a.m., Anthony Baker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46926/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 4:52 a.m.) > > > Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith. > > > Repository: geode > > > Description > ------- > > The GemFireVersion.properties file is generated by the build and > contains the git branch, commit, and source date. This change > caches the SCM info in the build root (.buildinfo) for use by the > source distribution. > > > Diffs > ----- > > geode-assembly/build.gradle e786b24b978c507905b36032f994158addde73e8 > geode-core/build.gradle 45051dc771452bf06ba6708efd8e1361791e13e8 > gradle/rat.gradle f35b157d510fd4ee6b3124de8ae94e30d3cd86c7 > > Diff: https://reviews.apache.org/r/46926/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Baker > >
