----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47046/#review131963 -----------------------------------------------------------
Wait is deprecated. Use Awaitility. And, looking it your code, I don't think it will ever recheck the condition. It's only going to set the vm0_proxy, vm1_proxy fields once. - Dan Smith On May 5, 2016, 11:04 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47046/ > ----------------------------------------------------------- > > (Updated May 5, 2016, 11:04 p.m.) > > > Review request for geode and Dan Smith. > > > Bugs: geode-1183 > https://issues.apache.org/jira/browse/geode-1183 > > > Repository: geode > > > Description > ------- > > The test code is not mature enough. Sometimes it will fail when the primary > is not yet setPrimary(). > > > Diffs > ----- > > > geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java > 684660b > > Diff: https://reviews.apache.org/r/47046/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
