----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47143/#review132431 -----------------------------------------------------------
Ship it! Ship It! - Jens Deppe On May 10, 2016, 12:20 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47143/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 12:20 a.m.) > > > Review request for geode, Jens Deppe and Jinmei Liao. > > > Bugs: GEODE-951 > https://issues.apache.org/jira/browse/GEODE-951 > > > Repository: geode > > > Description > ------- > > GEODE-951: repackage GemFireParameterizedMessage and > GemFireParameterizedMessageFactory > > * move to package com.gemstone.gemfire.internal.logging.log4j.message > * add javadocs about original source of these classes > * add comments pointing out Geode optimizations in these classes > > Since these files were moved to a new package, I have annotated the two > classes to mark the lines with new javadocs or comments. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java > 5572d11 > > geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterLogger.java > f1e314a > > geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessage.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessageFactory.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessage.java > d638a8c > > geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessageFactory.java > f113aa6 > > Diff: https://reviews.apache.org/r/47143/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Kirk Lund > >
