> On May 10, 2016, 5:36 a.m., Jinmei Liao wrote: > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java, > > line 542 > > <https://reviews.apache.org/r/47146/diff/1/?file=1377229#file1377229line542> > > > > Is this method used anymore?
Yes, testExportConfig invokes it 5 times for consecutive export config invocations. - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47146/#review132377 ----------------------------------------------------------- On May 10, 2016, 12:30 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47146/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 12:30 a.m.) > > > Review request for geode, Jens Deppe and Jinmei Liao. > > > Bugs: GEODE-1369 > https://issues.apache.org/jira/browse/GEODE-1369 > > > Repository: geode > > > Description > ------- > > GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder > > * use TemporaryFolder for all disk files > * re-enable testAlterUpdatesSharedConfig (might be a FlakyTest) -- was > disabled for TRAC #52204 but it passes > * use static imports > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java > c342142 > > Diff: https://reviews.apache.org/r/47146/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Kirk Lund > >
