----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47195/ -----------------------------------------------------------
(Updated May 11, 2016, 6:20 p.m.) Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer. Changes ------- Previous diff may cause some tests to fail, since the ExecutorService is shutdown, it will not receive any new submission for other tests. One way to fix it is to use ExecutorCompletionService to make sure all fetch tasks are completed before second round of PUTs. However, such kind of change of product code is unnecessary. GEODE-699 is essentially a test issue, not a product bug. There is no need to change product code for the test to pass. So just change the tests to remove second round of PUTs. Repository: geode Description ------- When the fetch task threads are spawned in the client metadata service for single hop, It is possible that certain thread is still lingering during the second round of PUTs, which assumes all such fetch tasks should be completed at that time. The lingering thread causes the flag to be set, which results in test failure. The fix tries to shutdown the ExecutorService and make sure all fetch task threads are terminated before the second round of PUTs. So that there is no unexpected flag change in the second round. Diffs (updated) ----- geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java f79d6c6 Diff: https://reviews.apache.org/r/47195/diff/ Testing ------- Thanks, Jianxia Chen
