----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47253/ -----------------------------------------------------------
Review request for geode, anilkumar gingade and xiaojian zhou. Repository: geode Description ------- This test was failing with a couple of different race conditions 1) It was not waiting for updates to make it to the second client, causing assertion failures. I added a wait. 2) It was occasionally using a connection that was previously made to the server before it was killed, causing an unexpected socket closed. I refactored the test to not use internal APIs to do the put, but instead verify that the event was not sent to the client using a listener. I also did some cleanup of the test - extended JUnit4CacheTestCase, removed the waits, used awaitility, removed an almost duplicate disabled test method and added the one extra assertion from that duplicate test to the enabled test method. Diffs ----- geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/UpdatePropagationDUnitTest.java 69781c4ff855974aeb9d32f8aafbcf40af046dc1 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/UpdatePropagationPRDUnitTest.java 8edac456c2595f83eef26d1ae9d25065bf69a44d Diff: https://reviews.apache.org/r/47253/diff/ Testing ------- Thanks, Dan Smith
