> On May 10, 2016, 4:09 p.m., Dan Smith wrote: > > I thought we were going to continue to make precheckin run these tests. You > > should make precheckin depend on flakyTest. > > > > Weren't we going to run these with forkEvery 1? The ingregration tests run > > with forkEvery 1, and the dunits with forkEvery 30. These don't fork at > > all, so they may be even less stable running as part of this target.
I think some of us discussed the possibility of adding "flakyTest" to the end of "precheckin" and that the addition of "forkEvery 1" on the flakTest task might be a good start. If the flakies are still flickering during most precheckin runs then we might want to remove from precheckin. We would need a separate task (from precheckin) for the primary consourse pipeline so that flakyTest can be parallel and not block later build tasks. - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47157/#review132460 ----------------------------------------------------------- On May 10, 2016, 4:49 a.m., Anthony Baker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47157/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 4:49 a.m.) > > > Review request for geode, Dick Cavender, Kirk Lund, Mark Bretl, and Dan Smith. > > > Repository: geode > > > Description > ------- > > Add a new test task specifically for running tests annotated with > @FlakyTest. This allows us to isolate tests that exhibit > intermittent failures. Other changes include: > > - Exclude flaky tests from test, integrationTest, uiTest, and > distributedTest tasks > - Cleanup how tests are found using the minimum set of > include/exclude categories > > > Diffs > ----- > > gradle/test.gradle 2dd75210b38fe37120778e35a4f96dbd08de97fe > > Diff: https://reviews.apache.org/r/47157/diff/ > > > Testing > ------- > > Tested by running test, flakyTest, integrationTest. Will run further tests > before pushing. > > > Thanks, > > Anthony Baker > >
