> On May 10, 2016, 12:41 a.m., John Blum wrote: > > @Kirk - note, I removed the offending code > > (https://github.com/spring-projects/spring-data-gemfire/commit/b42442d9cdd361286f883701f2aabc5cf2f0f038) > > in SDG. At the time, when I worked with Sourahb on this, this was the > > only way to cleanup after Cluster Config during tests. Note, by default, > > Cluster Config is disabled in SDG. However, I should add, even with this > > method, combined with additional initialization logic, it proved unreliable > > during subsequent forked Locator restarts.
Thanks John! - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47145/#review132360 ----------------------------------------------------------- On May 10, 2016, 12:25 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47145/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 12:25 a.m.) > > > Review request for geode, Jens Deppe and Jinmei Liao. > > > Bugs: GEODE-1370 > https://issues.apache.org/jira/browse/GEODE-1370 > > > Repository: geode > > > Description > ------- > > GEODE-1370: fix SDG by renaming > SharedConfiguration.destroySharedConfiguration_forTestsOnly back to > destroySharedConfiguration > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/SharedConfiguration.java > 0f349e9 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationDUnitTest.java > c07eab7 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationTestUtils.java > 235f02e > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java > 9cbb12c > > Diff: https://reviews.apache.org/r/47145/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Kirk Lund > >
