----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47327/#review133008 -----------------------------------------------------------
Ship it! You also fixed the 2 lines (one for classes, one for resources) in tomcat7. That's good. - xiaojian zhou On May 13, 2016, 12:14 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47327/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 12:14 a.m.) > > > Review request for geode, Jens Deppe, Mark Bretl, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > We were seeing compile errors in eclipse due to: > 1) Missing gradle output dirs in the extensions module. I removed those > dirs from the eclipse classpath > > 2) Access restrictions on things like Unsafe. This was caused by a > change in gradle 2.12 to add the java 1.8 execution environment, rather > than the direct JDK dependency, to the project. That turned on access > restrictions in eclipse for the execution environment. > > > Diffs > ----- > > extensions/geode-modules-tomcat7/build.gradle > 975c97672f2264d8fca75ae1d91934abc9e27180 > gradle/ide.gradle adaf8d98fcaf933c06b5acc2977ca5d37f3b1614 > > Diff: https://reviews.apache.org/r/47327/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
