----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47323/#review133013 -----------------------------------------------------------
I don't see the test class for this. Can you please attach it. - Udo Kohlmeyer On May 12, 2016, 8:10 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47323/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 8:10 p.m.) > > > Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > We were not handling list inside list immediately. Fixed it in PdxListHelper, > where we add java list in parent list. > Added test for it. Added one more state LIST_ENDS for readability purpose > > > Diffs > ----- > > geode-core/src/main/java/com/gemstone/gemfire/pdx/JSONFormatter.java > 220deaf > > geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/json/PdxListHelper.java > 7700b30 > > geode-core/src/test/resources/com/gemstone/gemfire/pdx/jsonStrings/jsonListInsideList.txt > PRE-CREATION > > Diff: https://reviews.apache.org/r/47323/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
