----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47326/#review133177 -----------------------------------------------------------
Ship it! I like the DiskDirRule. Are there any consequences to creating the default disk store in the cache for every test run? - Barry Oglesby On May 13, 2016, 12:13 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47326/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 12:13 a.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > In addition to the tests, I fixed some code to properly propagate the > disk synchronous flag to the index. > > > Diffs > ----- > > geode-core/src/test/java/com/gemstone/gemfire/test/fake/Fakes.java > 99644b7ff55f7af758280d285b632c799f21dd88 > > geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/DiskDirRule.java > PRE-CREATION > > geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/DiskDirRuleTest.java > PRE-CREATION > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java > dd9d38420ad6593b0fcafe52696e09ea8ff3feff > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneQueryFactoryImpl.java > c6087ea3634ae77a2831ba869a6e4513e6284f4f > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java > 07050e2f6fa41ce7c58ec8af08d5d868c8f2cd80 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationIntegrationTest.java > 2d16e32e05a95d93f6d31a2a178c207a219fe1e8 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIntegrationTest.java > 8c6f59ea3ebf8429915c5e1aff65af416d01874e > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java > 984b221edf826b5e79a5f498dc63e4f1f4774572 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneQueryFactoryImplJUnitTest.java > 0614e62a74ab497f7f2ab54b8a29792b3eede82a > > Diff: https://reviews.apache.org/r/47326/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
