----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47435/#review133475 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On May 16, 2016, 5:32 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47435/ > ----------------------------------------------------------- > > (Updated May 16, 2016, 5:32 p.m.) > > > Review request for geode, Darrel Schneider and Kevin Duling. > > > Bugs: GEODE-1392 > https://issues.apache.org/jira/browse/GEODE-1392 > > > Repository: geode > > > Description > ------- > > GEODE-1392: add tests for BlobHelper > > * create BlobHelperTest with basic unit tests > * create BlobHelperWithThreadContextClassLoaderTest with TCCL related tests > * remove deadcode > * minor cleanup of format > > > Diffs > ----- > > geode-core/src/main/java/com/gemstone/gemfire/internal/util/BlobHelper.java > 28252c3 > > geode-core/src/test/java/com/gemstone/gemfire/internal/util/BlobHelperTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/util/BlobHelperWithThreadContextClassLoaderTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/util/SerializableImpl.java > 44a8363 > > geode-core/src/test/java/com/gemstone/gemfire/internal/util/SerializableImplWithValue.java > 5727ff8 > geode-core/src/test/java/com/gemstone/gemfire/internal/util/Valuable.java > f58deb9 > > Diff: https://reviews.apache.org/r/47435/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Kirk Lund > >
