----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47429/#review133559 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java (line 310) <https://reviews.apache.org/r/47429/#comment198056> Pass lowSize as an argument to be able to unit test combineIfAdjacent, so that it can get coverage. Also mocking combineIfAdjacent to return false we can test the code path with out allocating adjacent memories bigger than 2G - Sai Boorlagadda On May 16, 2016, 11:19 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47429/ > ----------------------------------------------------------- > > (Updated May 16, 2016, 11:19 p.m.) > > > Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai > Boorlagadda. > > > Bugs: GEODE-1292 > https://issues.apache.org/jira/browse/GEODE-1292 > > > Repository: geode > > > Description > ------- > > change defragment to not create fragments > 2G > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java > c5e17e860e8e3300aac490621ae5d5b50f3a0e38 > > Diff: https://reviews.apache.org/r/47429/diff/ > > > Testing > ------- > > precheckin > > I looked over the code to see if I could create a unit test that does not > need to allocate 2G chunks of off-heap memory and it was not possible without > major refactoring. The problem is that we modify size fields stored at an > address during defragmentation and currently that requires that the address > be a valid off-heap memory address. > > > Thanks, > > Darrel Schneider > >
