----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47494/#review133654 -----------------------------------------------------------
Ship it! The lock service test changes look fine to me - Bruce Schuchardt On May 17, 2016, 10:12 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47494/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 10:12 p.m.) > > > Review request for geode, Anthony Baker and Bruce Schuchardt. > > > Repository: geode > > > Description > ------- > > Setting a system property to disable launching dunit VMs during > checkMissedTests. > > DistributedLockServiceDUnitTest failed with this property set because it > was doing work in the constructor. I cleaned up the test to create the > blackboard in the set up method instead. > > Check missed tests is now down to about 20s on my computer, from 50s before. > It looks like now powermock is the biggest culprit - see my comments on > GEODE-1378. > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedLockServiceDUnitTest.java > 42c3f01bf74f676c72fe2b6a0890f5a58ce35044 > gradle/test.gradle 96fbfc5ac94c8568d083e55dabff8e404c03d3b5 > > Diff: https://reviews.apache.org/r/47494/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
