----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47372/#review133759 -----------------------------------------------------------
Did you run `HelpCommandsJUnitTest` against these changes? I would have expected it to fail and you would have had to make changes there too. If you did run it and it didn't fail then it's probably broken and I'd like to know. - Jens Deppe On May 13, 2016, 11:05 p.m., anilkumar gingade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47372/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 11:05 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider, > Jason Huynh, Jens Deppe, Kirk Lund, nabarun nag, Dan Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > GEODE-1209: Added gfsh support to set ignoreEvictionAndExpiration attribute > for create AEQ command. Also cleaned up arguments for create AEQ function > invoked by gfsh. Instead of object array the args are wrapped in args object. > > > Diffs > ----- > > > geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java > 653bbdc > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommands.java > 89534a6 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/AsyncEventQueueFunctionArgs.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/CreateAsyncEventQueueFunction.java > 7481c0e > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java > 9bb573b > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/QueueCommandsController.java > b8353fa > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java > 691533d > > Diff: https://reviews.apache.org/r/47372/diff/ > > > Testing > ------- > > > Thanks, > > anilkumar gingade > >
