----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47567/#review133971 -----------------------------------------------------------
Ship it! Ship It! - Kirk Lund On May 19, 2016, 3:03 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47567/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 3:03 p.m.) > > > Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-17: clean up error messages > > * clean up authentication/authorization error messages > * Catch Authorization exception later in the command chain to avoid > unnecesary parsing of command result > * Add ExceptionHandler in controller to set the http header correctly > * Catch Authorization exception in gfsh execution for better error report > > Output: > gfsh>connect --user=guest > password: ***** > Connecting to Locator at [host=localhost, port=10334] .. > Connecting to Manager at [host=10.0.0.245, port=1099] .. > Successfully connected to: [host=10.0.0.245, port=1099] > > gfsh>list members > Unauthorized. Reason : Subject does not have permission [CLUSTER:READ] > > gfsh>disconnect > Disconnecting from: 10.0.0.245[1099] > Disconnected from : 10.0.0.245[1099] > > gfsh>connect --use-http --user=guest > password: ***** > Successfully connected to: GemFire Manager HTTP service @ > http://localhost:7070/gemfire/v1 > > gfsh>list members > Unauthorized. Reason : The HTTP request failed with: 403 - Subject does not > have permission [CLUSTER:READ]. > > gfsh>list clients > Unauthorized. Reason : The HTTP request failed with: 403 - Subject does not > have permission [CLUSTER:READ]. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java > 236b00b2e93f38074da24e157222c2146133decb > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java > 67ad60d55ada59a9376a92d3d828739481013c95 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/remote/CommandProcessor.java > 7edc3e418e272dde61225655606b95f3ef456984 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/result/ResultBuilder.java > 6b435d36bfae4adac44140f07b87a70ea3268d8d > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshExecutionStrategy.java > c5ebe9af351a6d73e470697196d890285b88c6c7 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java > ab49270110c46cc7068d0910a5b8e9ed675f1ed5 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java > c41197241789eee0fe97de4531f1bbe85b874360 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/shell/AbstractHttpOperationInvoker.java > b2159d26d84cda2580ac7117e17c2c083db812f7 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java > 377ab7761976d12c5915bba3999a0e0e272112c7 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MemberMBeanSecurityJUnitTest.java > 8261d09a0d3181d26f487602901ab5fb22d051c0 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/WanCommandsControllerJUnitTest.java > 03d39fdb7553a1797ac438f4c39ced6f22003419 > > Diff: https://reviews.apache.org/r/47567/diff/ > > > Testing > ------- > > precheckin successful > > > Thanks, > > Jinmei Liao > >
