----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47496/#review134033 -----------------------------------------------------------
Ship it! Ship It! - Dan Smith On May 19, 2016, 6:32 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47496/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 6:32 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan > Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Added integration tests to test three scenarios: > 1.) the lucene indexes are not updated during an in flight transaction (begin > but before rollback or commit) > 2.) the lucene indexes are updated after a commit > 3.) the lucene indexes are not changed after a rollback > > todo: > Do we want to add a dunit test for multiple vms and threads doing > transactions? I avoided adding this test for now as I thought that was more > of a "testing the geode transaction feature" rather than testing how the > feature affects lucene. > > > Diffs > ----- > > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationIntegrationTest.java > 4c28938 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java > 23983cb > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIntegrationTest.java > c302460 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java > fa3392c > > Diff: https://reviews.apache.org/r/47496/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
