----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47615/ -----------------------------------------------------------
(Updated May 19, 2016, 10:54 p.m.) Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider, Jason Huynh, nabarun nag, Dan Smith, and xiaojian zhou. Changes ------- Based on review removed waits for events that were not needed... Repository: geode Description ------- GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that by checking operations/events that happend before stop and not counting the changes happened during stop. In a slower environment, it could so happen that the CQ may not have recieved all the events before it is stopped, thus causing the validation to fail. Diffs (updated) ----- geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java 130f924643ad350539f02a59f34b6ba18cef1c10 Diff: https://reviews.apache.org/r/47615/diff/ Testing ------- Reproduced the issue by slowing down the CQ listener processing. Verified the test passes with the changes... Thanks, anilkumar gingade