-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47649/
-----------------------------------------------------------
Review request for geode, Jens Deppe, Jinmei Liao, and Kevin Duling.
Bugs: GEODE-835
https://issues.apache.org/jira/browse/GEODE-835
Repository: geode
Description
-------
JoptOptionParser is the primary Geode class that uses joptsimple. Creating
JoptOptionParserTest should make replacing joptsimple much safer.
Changes also includes refactoring Exceptions used by JoptOptionParser. I'd like
to do some further refactoring with this (and remove ExceptionGenerator), but I
think these changes are now at a good milestone to merge to develop. I'll
continue aditional changes on feature/GEODE-835 on which I'm removing
geode-joptsimple.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/CommandManager.java
46a8226
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandException.java
eb019a7
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandInvalidException.java
6fde9db
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandMultiModeOptionException.java
5f5cbfd
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandNotAvailableException.java
cf8bc06
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandOptionException.java
bfe6c3a
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandOptionHasMultipleValuesException.java
3932636
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandOptionInvalidException.java
af7e44a
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandOptionMissingException.java
00481fc
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandOptionNotApplicableException.java
4e99ba1
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandOptionValueConversionException.java
b16c8f2
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandOptionValueException.java
774a8b1
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliCommandOptionValueMissingException.java
4eb2a6b
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/CliException.java
bc0db3f
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/exceptions/ExceptionGenerator.java
6824735
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/Option.java
09aabd8
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/jopt/JoptOptionParser.java
6e56bf4
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/JoptOptionParserTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47649/diff/
Testing
-------
precheckin (in progress)
Thanks,
Kirk Lund
