----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47748/#review134612 -----------------------------------------------------------
Ship it! I understand the reasoning behind the test implementation and seems acceptable to me. - Ken Howe On May 24, 2016, 4:22 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47748/ > ----------------------------------------------------------- > > (Updated May 24, 2016, 4:22 p.m.) > > > Review request for geode, Scott Jewell and Ken Howe. > > > Bugs: GEODE-1424 > https://issues.apache.org/jira/browse/GEODE-1424 > > > Repository: geode > > > Description > ------- > > change isEmpty to use size > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalDataSet.java > d8e48e13ea019b19e508ad9987c2789918a14189 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/LocalDataSetTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47748/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
