----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47740/#review134792 -----------------------------------------------------------
Fix it, then Ship it! Fix it and ship it! geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/SecurityDUnitTest.java (line 64) <https://reviews.apache.org/r/47740/#comment199701> Hoist this out to a private static Logger. Every call to getLogger creates a FasterLogger instance and this is inside a for-loop. geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/SecurityDUnitTest.java (line 83) <https://reviews.apache.org/r/47740/#comment199702> Same. Use a static Logger instance. - Kirk Lund On May 23, 2016, 8:49 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47740/ > ----------------------------------------------------------- > > (Updated May 23, 2016, 8:49 p.m.) > > > Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-17: create muti-user security DUnit tests > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java > b863737538bde99e2756ba4e1a1b9a4d93c17b12 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java > a0966f9d70eec7b7835126cdcb05adeb1cc84269 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java > 3ccd71c48db8bb3a64c03d58f8c45ec3339a0a93 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java > 63bf4473232f955ee67d94e33083867a8fe954a1 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java > 1a153679e98b7c26652793c60b687f6db398426c > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/SecurityDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java > 4b482a97ba401e3e300bfc43587dd6a12ec84295 > > Diff: https://reviews.apache.org/r/47740/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
