----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47834/#review134793 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java (lines 289 - 292) <https://reviews.apache.org/r/47834/#comment199705> This should probably be a Java assert rather throwing the UnsupportedOperationException, similar to the fix for GEODE-1296 - Ken Howe On May 25, 2016, 4:59 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47834/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 4:59 p.m.) > > > Review request for geode, Eric Shu, Ken Howe, and Sai Boorlagadda. > > > Bugs: GEODE-1451 > https://issues.apache.org/jira/browse/GEODE-1451 > > > Repository: geode > > > Description > ------- > > The boolean parameters have been removed and two > methods now exist: > 1. decodeAddressToRawBytes(long) > 2. decodeUncompressedAddressToBytes(long) > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java > 8b57c43b0d4d31b8c5691a11f82a0acaad1340aa > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/TinyStoredObject.java > aee1b15e46df8b44d5d22a63263ae24fb6fab6bb > > geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java > b9b3dfcc831453951d0954b482a8ec6f72262eb5 > > Diff: https://reviews.apache.org/r/47834/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
