----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47803/#review134801 -----------------------------------------------------------
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java (line 73) <https://reviews.apache.org/r/47803/#comment199714> If we wanted to do something similar we could change SerializerUtil to detect a null value and stuff a token in, but do we want to do that? - Jason Huynh On May 25, 2016, 12:20 a.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47803/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 12:20 a.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-1453 > https://issues.apache.org/jira/browse/GEODE-1453 > > > Repository: geode > > > Description > ------- > > The field value could be null, when creating index, we need to handle it. > > > Diffs > ----- > > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java > 3990614 > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java > a76478c > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java > 4ebb9c4 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxFieldMapperJUnitTest.java > 278e818 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionFieldMapperJUnitTest.java > c187022 > > Diff: https://reviews.apache.org/r/47803/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
