----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47852/ -----------------------------------------------------------
Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund. Repository: geode Description ------- * refactor the connect command for better readability and retry handling * throw AuthenticationFailedException for consistency Diffs ----- geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 4eafada199b5a6fb1e9a507eb0db02cc9525d0a3 geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/JMXShiroAuthenticator.java 984a2bfaf8f81a4bce0bcfcbe0ee0f64eaccd912 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java ceb6cb9fe1967f9393073260495259a98d94fc1d geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java baf30493dcdb7d67a6d43e9dfd9338435fc736b2 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshExecutionStrategy.java 0cfae9c38e504250c2c2e857c389b508c9ec246a geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceConstants.java 5e072d983b4e0c7c62f4d05040b06c096816f2b5 geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/http/support/SimpleHttpRequester.java da9966d3d667e3e4b5f448aee3c65c0aa06a46f8 geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/shell/AbstractHttpOperationInvoker.java 944644fa699cccf9fc438cc5319841761e06e233 Diff: https://reviews.apache.org/r/47852/diff/ Testing ------- precheckin running. Manual testing: gfsh>connect Connecting to Locator at [host=localhost, port=10334] .. Connecting to Manager at [host=10.234.255.11, port=1099] .. username: guest password: **** Could not connect to : [host=10.234.255.11, port=1099]. Authentication error. Please check your username/password. gfsh>connect --use-http username: guest password: **** The HTTP request failed with: 401 - Not authenticated gfsh>connect --user=guest password: ***** Connecting to Locator at [host=localhost, port=10334] .. Connecting to Manager at [host=10.234.255.11, port=1099] .. Successfully connected to: [host=10.234.255.11, port=1099] gfsh>disconnect Disconnecting from: 10.234.255.11[1099] Disconnected from : 10.234.255.11[1099] gfsh>connect --use-http --user=guest password: ***** Successfully connected to: GemFire Manager HTTP service @ http://localhost:7070/gemfire/v1 gfsh>disconnect Disconnecting from: GemFire Manager HTTP service @ http://localhost:7070/gemfire/v1 Disconnected from : GemFire Manager HTTP service @ http://localhost:7070/gemfire/v1 gfsh>connect Connecting to Locator at [host=localhost, port=10334] .. Connecting to Manager at [host=10.234.255.11, port=1099] .. username: password: Could not connect to : [host=10.234.255.11, port=1099]. Missing Credentials. Please supply username/password. gfsh>connect --use-http username: password: The HTTP request failed with: 401 - Not authenticated Thanks, Jinmei Liao
