----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48076/#review135688 -----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContextJUnitTest.java (line 33) <https://reviews.apache.org/r/48076/#comment200706> Changes in this file are not necessary, correct? geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java (line 28) <https://reviews.apache.org/r/48076/#comment200707> changes in this class are not necessary as well. geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt (line 133) <https://reviews.apache.org/r/48076/#comment200704> Now that ResourceOperationContext is not public, should it still be listed here? - Jinmei Liao On May 31, 2016, 9:27 p.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48076/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 9:27 p.m.) > > > Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > - Moved ResourceOperationContext into a 'public' package. > - Converted OperationContext into an interface. > - Cleaned up the hierarchy of everything that previously > extended OperationContext. > - Marked GetOperationContext as abstract seeing that > GetOperationContextImpl extends it and there are no uses of > GetOperationContext anywhere. (So why does it still exist?). > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/CloseCQOperationContext.java > 3a29981d0712bb9bb609731b818702a4d36f91cc > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/DestroyOperationContext.java > 48ae9e519ecb10fa1209428b243e12d6f0cba0a1 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/ExecuteCQOperationContext.java > b4a07648726dc51ed4d9ec0ee68c2133af411c61 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/ExecuteFunctionOperationContext.java > e6bd455c0faa15e7ca63a6f96d8adb4f93043a8b > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetDurableCQsOperationContext.java > a8de1a95e4aea8f077022fe0bb1d83bddf53c09b > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetOperationContext.java > 43b9e3aab0a20d2c149879bb04977631dd4e918a > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/InterestOperationContext.java > 79632551bd73e9d3806323fa29ca06704547c7f8 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/InvalidateOperationContext.java > 75b0c3754e317a73b45cc5955edfbe3da0a162a6 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyOperationContext.java > 71430afff5eeac8ed611461a7f2537bf25ffd9a1 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeySetOperationContext.java > 5c0eeb91f0337e317a17c990eebc4331f90d3179 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyValueOperationContext.java > 7f7ab8c404ce7ac47643eaad9723f83780fcba55 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java > 317fee6b62d084716565f008d4d99ea6376b28dc > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutAllOperationContext.java > aff44962377f8862e40aa0ca029035780bc0c0c3 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutOperationContext.java > 867c25617d96b9404875e0b738ea63295b7b4bf3 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/QueryOperationContext.java > f9711b7e64bfac5033805410dea7488439add9ec > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionClearOperationContext.java > 370ec6e87d67b03dd94f2eecd5f5777fedbe11e7 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionCreateOperationContext.java > 430ed084c4f564fddbf32f2358474b824951ab8a > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionDestroyOperationContext.java > d4693d04d88d8768ba0b73911716fcb701157b0b > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionOperationContext.java > ba199c6f84539cb474356c023cde251de67267ec > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegisterInterestOperationContext.java > 4189c31c85b017d3a434fa6833301925bee5bd45 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RemoveAllOperationContext.java > ebc3694d50abc219855ad7988f2a5f36bafb20b0 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/StopCQOperationContext.java > 1c28f75aa4d12dc24daa30e784b87dbbce0b1ebd > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/UnregisterInterestOperationContext.java > 078066e2575a812f66c2de42d4245ec6a35eb620 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/internal/GetOperationContextImpl.java > f664061cdb28b6fd0de0d2cede88d55062046b92 > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/internal/ResourceOperationContext.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerToClientFunctionResultSender.java > 14b81a19a618ad997d5fc389508c01f199d3c138 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/operations/ContainsKeyOperationContext.java > b3a7536fddbc650ec7259d0798505ec65ee69853 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/BaseCommandQuery.java > 3a80e25a6f070b3e8cf27ca49dea9d074e4b5f18 > > geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java > f8da7a8a7217b04a2cb254f1b654bd8e7ce4cca2 > > geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java > cb2b66be94f046dc60f811bceccdc68a239299e3 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/MBeanServerWrapper.java > 99cbe2e4c5f11cd2adfc40637f9e949a04d0ff61 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java > 99da1f1abe00feddc806ca012d9a5d2c1ccd75b5 > > geode-core/src/test/java/com/gemstone/gemfire/cache/operations/OperationPartsJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ExampleJSONAuthorization.java > f34be0b5ce4d833b60a20dced38a57e72eda1670 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java > ac81c76a50ce31e8061d91c4789f1a8479919a48 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContextJUnitTest.java > 46c0e1ddb0ed7b0f9d881da48d6ce53bc3097e41 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java > 2ddc6eee691b7305a0618f9a40e03a39526bc7b5 > > geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt > 89305acea1887fcf2edba17b91362bbfc53c5703 > > Diff: https://reviews.apache.org/r/48076/diff/ > > > Testing > ------- > > Ran precheckin > > > Thanks, > > Jens Deppe > >
