----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48153/#review135857 -----------------------------------------------------------
Ship it! Ship It! - Dan Smith On June 1, 2016, 8:48 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48153/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 8:48 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan > Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Due to the method signature of verifyQueryKeys using the types supplied by > the LuceneQuery argument, it was expecting Object... > In this specific usage, we are actually always passed String... as the > expectedKeys. So instead of changing the method signature of verifyQueryKeys > or casting a String[] to an Object[], I just changed the LuceneQuery types > from <Object, Object> to <String, Object> > > > Diffs > ----- > > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java > 13df7a9 > > Diff: https://reviews.apache.org/r/48153/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
