Github user bschuchardt commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/152#discussion_r66147139
  
    --- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/Gfsh.java
 ---
    @@ -279,7 +281,12 @@ protected Gfsh(boolean launchShell, String[] args, 
GfshConfig gfshConfig) throws
       private void initializeEnvironment() {
         env.put(ENV_SYS_USER,              System.getProperty("user.name"));
         env.put(ENV_SYS_USER_HOME,         System.getProperty("user.home"));
    -    env.put(ENV_SYS_HOST_NAME,         System.getProperty("user.name"));
    +    try {
    +      env.put(ENV_SYS_HOST_NAME,       
InetAddress.getLocalHost().getHostName());
    --- End diff --
    
    Use SocketCreator.getLocalHost() and SocketCreator.getHostName().  
SocketCreator caches host names to avoid going to DNS when the host name is 
already known.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to