Ideally we would want to group static all together, other (non-GemFire related) all together and then all GemFire related together. Because of 1) the mix of hydra packages and 2) com.vmware.gemfire & io.pivotal.geode we can only group GemFire related together in IntelliJ (we can't do this in Eclipse).
In order to support Eclipse and IntelliJ, we are left with only two options: 1) insert <blank line> between every block in the IntelliJ import layout (which gives us a pretty weird ordering in my opinion) or 2) give up and just alphabetize everything in one giant block that's only separated from the static imports Preferences? -Kirk On Thu, Jun 9, 2016 at 11:24 AM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: > I really don't have a preference in regards to import formatting, as long > as Eclipse and Intellij do the same thing. > > --Udo > > > > On 10/06/2016 3:54 am, Kirk Lund wrote: > >> Sorry this is such a mess. Please vote on how you want it to work and then >> after everyone finishes voting, I'll update both to be the same as each >> other. >> >> -Kirk >> >> >> On Thu, Jun 9, 2016 at 10:53 AM, Kirk Lund <kl...@pivotal.io> wrote: >> >> The Eclipse formatter has now been updated to match the IntelliJ formatter >>> as closely as possible. Below is detailed descriptions of the changes: >>> >>> 1) rename Eclipse formatter Profile Name from GemFire to Geode >>> >>> 2) update Organize Imports to following order: >>> >>> all unmatched static imports >>> <blank line> >>> java imports >>> <blank line> >>> javax imports >>> <blank line> >>> all unmatched type imports >>> <blank line> >>> batterytest.* (hydra) >>> <blank line> >>> cacheRunner.* (hydra) >>> <blank line> >>> hydra.* (hydra) >>> <blank line> >>> parReg.* (hydra) >>> <blank line> >>> perffmwk.* (hydra) >>> <blank line> >>> com.gemstone.* (geode/gemfire code) >>> <blank line> >>> com.vmware.gemfire.* (geode/gemfire code) >>> <blank line> >>> io.pivotal.geode.* (geode/gemfire code) >>> >>> (each of the above groups are separated by one blank line -- this is same >>> as before) >>> >>> The changes to the IntelliJ formatter: >>> >>> 1) rename IntelliJ formatter from gemfireCodeStyleScheme to >>> geodeCodeStyleScheme >>> >>> 2) update Import Layout to following order: >>> >>> Import static all other imports >>> <blank line> >>> import java.* >>> import javax.* >>> <blank line> >>> import all other imports >>> <blank line> >>> import batterytest.* >>> import cacheRunner.* >>> import hydra.* >>> import parReg.* >>> import perffmwk.* >>> <blank line> >>> import com.gemstone.* >>> import com.vmware.gemfire.* >>> import io.pivotal.geode.* >>> >>> I prefer the IntelliJ import layout, BUT I couldn't perfectly control >>> where the <blank lines> are inserted in the Eclipse formatter. Apparently >>> every block of related imports just automatically gets surrounded by a >>> <blank line>. >>> >>> Should we import <blank line> between every block in IntelliJ to match >>> Eclipse? >>> >>> -Kirk >>> >>> >>> >
