----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48658/#review137345 -----------------------------------------------------------
Ship it! I don't think we want to use the first field as the default field long term. That's behavior that might be confusing to users, especially since the order of the fields is not really defined if you pass in a map of fields->analyzers. - Dan Smith On June 13, 2016, 5:59 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48658/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 5:59 p.m.) > > > Review request for geode, anilkumar gingade, nabarun nag, Dan Smith, and > xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Removed tests specific to multi field query parsing > Currently using the first field as the default field. Future changes will > allow user to pass in a default field. > > > Diffs > ----- > > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java > 62cb65c > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProviderJUnitTest.java > cfd8c32 > > Diff: https://reviews.apache.org/r/48658/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
