-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48665/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
Bugs: GEODE-1542
https://issues.apache.org/jira/browse/GEODE-1542
Repository: geode
Description
-------
This disables timing out of shared/unordered TcpConduit connections. We don't
want them to time out because we are using them to initiate suspect processing
on other members.
The ticket also pointed out a problem with the "final check" mechanism in the
health monitor. I tracked that down to improper use of SocketCreator to create
the server-socket in GMSHealthMonitor. It was creating sn SSL socket if SSL is
enabled but the client-side of the check uses non-SSL sockets. I changed the
server to use non-SSL sockets as well since no useful information is sent over
the final-check TCP/IP connections & they need to be lightweight and fast.
While looking at logs I also found that the heartbeat request sent at the
beginning of a final-check had a request-ID even though it's not waiting for a
response. That causes processing of the response to do more work than
necessary so I changed it to remove the request-ID from the message.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
f27e0b8d238fd4cda3a81a5d1edf199ebeb1c3c7
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java
8dce1a5eb46b26a7b9ecc3e5b538d98e7e9f720e
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/HeartbeatRequestMessage.java
3c08e3383c2bf8f53cca291825ddb45ef69d0184
geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java
367d4a7bbe1334ad393da337030a1d02089cfcaf
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java
85e351106285db571ecc3f388bbb11979562c3ed
Diff: https://reviews.apache.org/r/48665/diff/
Testing
-------
precheckin, SSL integration testing.
Thanks,
Bruce Schuchardt
