> On June 14, 2016, 5:07 p.m., Jason Huynh wrote: > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogeneousLuceneSerializer.java, > > line 71 > > <https://reviews.apache.org/r/48699/diff/1/?file=1418740#file1418740line71> > > > > If they specify the REGION_VALUE_FIELD in a list of fields, that would > > create an indexed field out of all their searchable fields? > > > > Should we check to see if the list is size of 1 also and prevent them > > from doing that? > > Dan Smith wrote: > The behavior the way it's written in this diff is that if > REGION_VALUE_FIELD is present, and the value they are putting is a String or > Number, then it will create an indexed field. If their value is a complex > object, this REGION_VALUE_FIELD will be ignored and do nothing. > > If you think it's a good idea to prevent people from mixing this > REGION_VALUE_FIELD with other fields, I can add a check to prevent that.
No actually I think this works better in that they can have heterogenous objects in the odd cases where they would want it. Just wanted to make sure we weren't having it index all primitive types to this field but I think I get it now. Thanks! - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48699/#review137544 ----------------------------------------------------------- On June 14, 2016, 5:02 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48699/ > ----------------------------------------------------------- > > (Updated June 14, 2016, 5:02 p.m.) > > > Review request for geode, anilkumar gingade, Jason Huynh, nabarun nag, and > xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Adding support to index values that are strings or numbers, by providing > a special field name LuceneIndex.REGION_VALUE_FIELD that indicates the > entire value should be indexed. > > > Diffs > ----- > > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneService.java > 462aa7e4010afdfed06cca23025638c0abbdeff3 > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java > 47c4d76eabd893c8ce6ab352eb3eb6993be78fc4 > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogeneousLuceneSerializer.java > d2b1db121fb4d626d71adaf850c33c968b8ad447 > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PrimitiveSerializer.java > PRE-CREATION > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/SerializerUtil.java > 0ed9d5d9ff366baf0418f0b1fd7eb8e7971690e8 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java > c26997d779e518c611de2693dad4c9799ce57691 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogeneousLuceneSerializerJUnitTest.java > 3bce9045d44430cbb0c7b5c182cbc156d7d7700a > > Diff: https://reviews.apache.org/r/48699/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
