----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48916/#review138623 -----------------------------------------------------------
Ship it! Ship It! - Jinmei Liao On June 18, 2016, 10:11 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48916/ > ----------------------------------------------------------- > > (Updated June 18, 2016, 10:11 p.m.) > > > Review request for geode, Anthony Baker, Grace Meilen, Hitesh Khamesra, Jens > Deppe, and Sai Boorlagadda. > > > Bugs: GEODE-1567 > https://issues.apache.org/jira/browse/GEODE-1567 > > > Repository: geode > > > Description > ------- > > GEODE-1567: update golden-help-offline for HelpCommandsIntegrationTest > > * update golden-help-offline.properties to match changes made for GEODE-985 > and GEODE-1408 > * restore geode.properties back to gemfire.properties in CliStrings until > GEODE-1466 is completed > * restore GeodeRedisServer back to GemFireRedisServer in CliStrings until > GEODE-1566 is completed > * fix typo for cacheLoader default in CreateAlterDestroyRegionCommands from > "help" to "null" > > This test is currently failing 100% in nightly build, precheckin and > integrationTest. This change will restore it back to passing 100%. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java > 741da25 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java > d5ebe4c > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HelpCommandsIntegrationTest.java > bbb11db > > geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties > 0cd7a07 > > Diff: https://reviews.apache.org/r/48916/diff/ > > > Testing > ------- > > HelpCommandsIntegrationTest and precheckin (latter is still running) > > > Thanks, > > Kirk Lund > >
