----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49035/ -----------------------------------------------------------
Review request for geode, Grace Meilen and Jinmei Liao. Bugs: GEODE-1565 https://issues.apache.org/jira/browse/GEODE-1565 Repository: geode Description ------- GEODE-1565: add quotes around any value starting with hyphen * refactor OptionJFormatter into HyphenFormatter to format all values starting with hypen Diffs ----- geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/GfshParser.java 0bf2f66 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/jopt/JoptOptionParser.java 04590ed geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/remote/CommandProcessor.java b62f922 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/HyphenFormatter.java PRE-CREATION geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/OptionJFormatter.java 0e3265a geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/GfshParserIntegrationTest.java 17e78a5 geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 553b7a4 geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/util/HyphenFormatterTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/util/OptionJFormatterTest.java 12dcd5e geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CommandOverHttpDUnitTest.java cad3f31 Diff: https://reviews.apache.org/r/49035/diff/ Testing ------- new tests in: * HyphenFormatterTest * GfshParserIntegrationTest * GemfireDataCommandsDUnitTest precheckin Thanks, Kirk Lund