----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49101/#review139307 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java (line 1561) <https://reviews.apache.org/r/49101/#comment204479> schedule will throw IllegalStateException if the cache is closing. It is probably worth catching it here and deciding what you want to do in that exceptional case. geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java (line 1582) <https://reviews.apache.org/r/49101/#comment204480> isEmpty is better than size() == 0 - Darrel Schneider On June 22, 2016, 3:47 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49101/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 3:47 p.m.) > > > Review request for geode, Darrel Schneider and Swapnil Bawaskar. > > > Bugs: GEODE-1546 > https://issues.apache.org/jira/browse/GEODE-1546 > > > Repository: geode > > > Description > ------- > > Move transactionTimeToLive setting in TXManagerImpl. > Update proxy server to track the latest proxy after failover. > Expire client transactions if they do not fail over to new proxy servers and > after transaction timeout period. > Add test cases for the above scenario. > Refactored the test code and made transactionTimeToLive setting adjustable to > reduce test running time. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractCacheServer.java > c9648a3 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerImpl.java > 2c72410 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessage.java > db5bcca > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java > 1ea7f71 > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java > c42f63c > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateProxy.java > ba9866e > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateProxyImpl.java > 0939ab0 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java > 14fce08 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java > ffcb8c5 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/BaseCommand.java > bdebb6b > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java > 30ab4a4 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientHealthMonitor.java > eb701fb > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheServerCreation.java > 22d684f > > geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java > 8f962f7 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java > 860833e > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImplJUnitTest.java > 7c52a89 > > Diff: https://reviews.apache.org/r/49101/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Eric Shu > >
