----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49329/#review139868 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java (line 162) <https://reviews.apache.org/r/49329/#comment205215> why make this concurrent? Every place (except close) that uses this map first synchronizes on it. geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java (line 589) <https://reviews.apache.org/r/49329/#comment205216> Why do you release the sync BEFORE iterating the hostedTXStates? - Darrel Schneider On June 28, 2016, 10:07 a.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49329/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 10:07 a.m.) > > > Review request for geode, Darrel Schneider and Swapnil Bawaskar. > > > Bugs: GEODE-1607 > https://issues.apache.org/jira/browse/GEODE-1607 > > > Repository: geode > > > Description > ------- > > Fix ConcurrentModificationException during cache close > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java > 1512234 > > Diff: https://reviews.apache.org/r/49329/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Eric Shu > >
