----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49481/#review140394 -----------------------------------------------------------
Looks good! I'm not sure how a feel about adding passing tests that assert that lucene is broken - if we upgrade lucene those tests might fail, right? Maybe it would be better to separate out your string query tests into separate tests that fail, and then mark those tests with @Ingore. That might be better documentation of what you expect to happen but currently does not work. - Dan Smith On June 30, 2016, 11:53 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49481/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 11:53 p.m.) > > > Review request for geode, anilkumar gingade and Dan Smith. > > > Bugs: GEODE-11 > https://issues.apache.org/jira/browse/GEODE-11 > > > Repository: geode > > > Description > ------- > > The code case archived following conclusions related with research on range > query > 1) lucene's QueryParser does not work for numeric range query > 2) Need a IntPoint.newRangeQuery to do numeric range query for int field. > Similar for float, double and long fields. > 3) If field has 2 values with different types, lucene will throw IAE. > 4) Define a sample implementation for LuceneQueryProvider. This can also be > used for demo or sample code for customer in the future. > > > Diffs > ----- > > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneQueryFactoryImpl.java > 62b4f56 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java > 988e4f5 > > Diff: https://reviews.apache.org/r/49481/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
