----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49904/#review141776 -----------------------------------------------------------
Ship it! Ship It! - anilkumar gingade On July 11, 2016, 5:13 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49904/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 5:13 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan > Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Map indexes were being passed just the key to match (for in queries), however > map indexes require an object[] where the first element is the key and the > second is the map key. > > We can look into changing this so that the indexes themselves handle this key > extraction, but that will be for another "improvement" ticket. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/CompiledIn.java > 71f9704 > > geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/CompiledInDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/PdxStringQueryDUnitTest.java > 5124d85 > > Diff: https://reviews.apache.org/r/49904/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
