----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49966/#review141994 -----------------------------------------------------------
Ship it! Update and ship it. - xiaojian zhou On July 12, 2016, 9:18 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49966/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 9:18 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, and > xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Testing failover of lucene indexes by closing the cache while in the > middle of updating lucene indexes. Currently there are tests for closing > the cache before the index repository commit, and also during the commit > after a fixed number of updates to the underling index data regions. > > I refactored the lucene tests to use 7 buckets, rather than 113, so they > take less time and are easier to debug. > > I also removed a call to Thread.interrupt in the WAN code because it was > interrupting itself in my callback. We should never be using interrupt > in the product. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java > 9cde6dd9b63e23ac3903c40e2d364766fffc725a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderEventProcessor.java > b63c7cbcda2cb610e07020607ae892377785e17b > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/IndexRepositoryFactory.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPRBase.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPRDUnitTest.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/IndexRegionSpy.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/IndexRepositorySpy.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/49966/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
